Skip to content

Comments

Update to c-kzg-4844 upstream#191

Merged
belijzajac merged 45 commits intomainfrom
update_upstream
Mar 9, 2023
Merged

Update to c-kzg-4844 upstream#191
belijzajac merged 45 commits intomainfrom
update_upstream

Conversation

@belijzajac
Copy link
Collaborator

@belijzajac belijzajac commented Feb 17, 2023 •
edited
Loading

This PR updates the interface following the c-kzg-4844 changes.

  • Update c-kzg-4844 git hash to 1493f2b
  • Add Go binding
  • Hook up C tests from c-kzg-4844
  • Benchmarks for the mcl backend
  • Refactor and clean up code

@belijzajac belijzajac self-assigned this Feb 17, 2023
belijzajac and others added 14 commits February 18, 2023 15:53
@belijzajac
Revert "Update mainnet and minimal trusted setups"
387ba87 
This reverts commit 62bc31f.
@belijzajac
Add benchmarks for mcl
6dae188
@belijzajac
Integrate Go binding
a703097
@belijzajac
Go binding's tests currently fail under mcl backend
3e7fe5d
@belijzajac
Hook up C tests
778f1ca
@belijzajac
Fix Clippy errors
3f5d545
@belijzajac
Prefer git patches to sed commands because the latter doesn't alert u…
f035e2b 
…s when the string sequences don't match
@belijzajac
Hook up mcl on C tests
c3828b9
@belijzajac
Add proper error reporting and update git patch
27e3281
@belijzajac
Fix git patch trailing space warnings
22a3c24 
Fix segmentation faults
@belijzajac
Fix undefined reference to ceil
647cc51
@nazar-pc
Switch to workspace, switch to git ssz-rs dependency to not use yanke…
7ebb051 
…d packages down the tree and make dependencies installable again
@nazar-pc
Fix compilation after ssz-rs dependency upgrade
d859ef0
@nazar-pc
Fix build.rs files to work properly under workspace and not write t…
55e196c 
…o source tree, make path to sed generic
@sauliusgrigaitis sauliusgrigaitis mentioned this pull request Feb 28, 2023
Merged
@sauliusgrigaitis sauliusgrigaitis mentioned this pull request Mar 3, 2023
Closed
@nazar-pc
Copy link
Contributor

nazar-pc commented Mar 3, 2023

Is there anything in particular left to be done in this PR before landing into main?

@belijzajac
Copy link
Collaborator Author

belijzajac commented Mar 3, 2023

Basically these three points:

  • Update the c-kzg-4844 git hash that is now 3 weeks old
  • Update blst-from-scratch and mcl implementations following the c-kzg-4844 changes
  • Make zkcryto and arkworks eip-4844 compliant (these can be lengthy processes that can be done by separate PRs)

@sauliusgrigaitis
Copy link
Member

sauliusgrigaitis commented Mar 3, 2023

I think zkcrypto and arkworks can wait, even mcl can wait if it takes too long.

@belijzajac
Copy link
Collaborator Author

belijzajac commented Mar 9, 2023

This is the last version that supports aggregate KZG proofs.

The 6 functions that made into proposal (ethereum/consensus-specs#3274 (comment)) require us to rewrite a significant amount of logic (commits: c9e7b65, aee67f6, 48c3cb5; CI: jobs/7632143695 and jobs/7631881052), effectively deprecating the majority of 4844 tests and benchmarks.

@belijzajac belijzajac marked this pull request as ready for review March 9, 2023 13:48
@belijzajac belijzajac merged commit 7eb52ca into main Mar 9, 2023
@belijzajac belijzajac deleted the update_upstream branch March 9, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@belijzajac belijzajac

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@belijzajac @nazar-pc @sauliusgrigaitis